Project

General

Profile

Bug #2285

Extreme lag with LAN discovery of multiple (12) local servers

Added by skyjake almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Defect
Target version:
Start date:
2018-10-03
% Done:

100%

Tags:

Description


Related issues

Related to Bug #2141: Use server IDs to detect which public/private entries belong to the same server in the Multiplayer listClosed2015-12-09

Associated revisions

Revision 2be0bd42 (diff)
Added by skyjake over 3 years ago

Performance: Manipulating and copying ServerInfos

The Record-based shell::ServerInfo was being copied multiple times continuously during discovery and update of servers. Apply a copy-on-write mechanism internally in ServerInfo so that it can be used more efficiently.

Also Address now caches localhost check results and the text representation of the address, so these don’t have to be done more than once.

IssueID #2285

History

#1 Updated by skyjake over 3 years ago

  • Related to Bug #2141: Use server IDs to detect which public/private entries belong to the same server in the Multiplayer list added

#2 Updated by skyjake over 3 years ago

d5ec468248 may help with this issue.

#3 Updated by tacgnol over 3 years ago

It helped, I went from 2 FPS to 10 or 23 when I check the FPS counter.

But I would say there is something else.

When I isolate my server on another vlan, my client have a steady 60 FPS.

#4 Updated by skyjake over 3 years ago

tacgnol wrote:

But I would say there is something else.

I agree. It is doing a lot of unnecessary work updating the list, because the logo loading is not something that should be occurring continuously.

#5 Updated by skyjake over 3 years ago

  • Status changed from New to In Progress

#6 Updated by skyjake over 3 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

The optimizations in 2be0bd42 should provide a sufficient performance improvement. Please test and check how well it works for you.

#7 Updated by tacgnol over 3 years ago

yeah, seems to be fixed now !

thanks again !

#8 Updated by skyjake over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF