Project

General

Profile

Bug #1090

Sv_RateDelta return code doesn't typecheck

Added by alpha7 almost 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
2012-09-20
% Done:

100%


Description

Sv_RateDelta of doomsday/engine/portable/src/sv_pool.c uses the following code in its return statement:

return (delta->score = score? true : false);

Thus either true or false is assigned to delta->score (which is of type float), and that again is supposed to be converted back to an expression of type boolean. The latter is an enum, and thus the conversion is undefined.

Best,
Michael

Labels: Networking, Server

History

#1 Updated by skyjake over 9 years ago

- priority: 5 --> 7

#2 Updated by skyjake about 9 years ago

- labels: --> Networking, Server
- status: open --> fixed
- assigned_to: Jaakko Keränen
- milestone: v1.9.0-beta6 --> v1.9.10
- priority: 1 --> 5

#3 Updated by skyjake almost 9 years ago

Fixed for 1.9.10.

Also available in: Atom PDF