Project

General

Profile

Bug #1029

Switch sound origin

Added by vermil over 10 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Vanilla emulation
Start date:
2012-04-19
% Done:

100%


Description

http://www.dengine.net/forums/viewtopic.php?f=9&p=6818#p6818

In Vanilla, the switch code specifies that a switch sound should play in the middle of the sector the switch is attached to.

However, a bug in the code changed this behaviour. This bug made it so that switch sounds were played at the location player is, when the switch is pressed (i.e to make it clear that the switch sounds didn't follow the player around if he moves during the sound playing).

Dday 1.9.7 fixed this 'bug' when the code was rewritten and restored the 'correct', but 'incorrect' behaviour, if you get what I mean.

From a gameplay perspective; you don't always have the time to look at a switch to see if you've hit it (i.e. to look for the change in graphic; i.e. the light on the switch changing). There are occasions where you rely on the sound to know you've hit it (such as when you are dodging bad guys).

Labels: Sound Effects


Related issues

Related to Feature #1520: Realistic switch sound origin (compatibility option)Closed2010-06-23

Associated revisions

Revision d1256985 (diff)
Added by skyjake over 5 years ago

Audio|API: Sound emitters are const in APIs; fixed line side emitters

All sound emitters are now passed as const pointers in API functions.

Line side emitters were not being initialized until the sector planes
moved.

IssueID #1029

Revision 0f5abef8 (diff)
Added by skyjake over 5 years ago

Audio|All Games: Added setting for switch sound positioning

The cvar “sound-switch-origin” determines where sound effects for
switches are positioned. The default is the intuitive position (the
line/switch itself). The alternative behavior (cvar value 1) is to
play switch sounds from the sector center, like in vanilla.

IssueID #1029

Revision 7e11c099 (diff)
Added by skyjake over 5 years ago

All Games|Menu: Added Gameplay menu option for switch sound positioning

IssueID #1029

History

#1 Updated by vermil over 10 years ago

To throw a little more into this; one can see that even the Iwad maps were clearly made expecting the 'bugged' behaviour.

#2 Updated by skyjake over 10 years ago

- milestone: v1.9.7_Unstable --> v1.9.7

#3 Updated by skyjake almost 10 years ago

I recall this was partially addressed recently by danij. What's the status?

#4 Updated by danij almost 10 years ago

All this now needs is for sound stopping to use the parameterised version of S_StopSound() and the addition of a couple of game-side cvars to make the default behavior optional.

#5 Updated by vermil about 7 years ago

  • Priority changed from Normal to Urgent

#6 Updated by skyjake about 7 years ago

  • Tags set to Audio, SFX, PlaySim, Gameplay
  • Target version deleted (1.9.7)

#7 Updated by skyjake about 7 years ago

  • Category set to Vanilla emulation

#8 Updated by skyjake over 6 years ago

  • Priority changed from Urgent to Normal

#9 Updated by skyjake over 6 years ago

  • Target version set to 2.0 – Home UI & Packages

#10 Updated by skyjake about 6 years ago

  • Status changed from New to Progressed

#11 Updated by skyjake over 5 years ago

  • Status changed from Progressed to In Progress
  • Assignee changed from danij to skyjake
  • % Done changed from 0 to 100

#12 Updated by skyjake over 5 years ago

  • Status changed from In Progress to Resolved

#13 Updated by sonicdoommario over 5 years ago

Quick question, could this be added to one of the options under compatibility settings to toggle on or off, so getting to it would be easier?

Thanks.

#14 Updated by skyjake over 5 years ago

Yeah I can add it to the menu, should be easy.

#15 Updated by skyjake over 5 years ago

  • Status changed from Resolved to Closed

#16 Updated by vermil almost 4 years ago

"The cvar “sound-switch-origin” determines where sound effects for
switches are positioned. The default is the intuitive position (the
line/switch itself). The alternative behavior (cvar value 1) is to
play switch sounds from the sector center, like in vanilla."

Does this mean there is no option for the sound to play at the players location when the switch is initially pressed (which was vanilla behaviour)?

In Vanilla, the switch on/off sounds are played at the spot the player was standing when they activated the switch (i.e if the player moves between the switch going on/off, the sound doesn't follow them).

#17 Updated by skyjake over 2 years ago

  • Related to Feature #1520: Realistic switch sound origin (compatibility option) added

Also available in: Atom PDF